Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic composition launch demo #324

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Add basic composition launch demo #324

merged 2 commits into from
Apr 24, 2019

Conversation

mjcarroll
Copy link
Member

No description provided.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Apr 23, 2019
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the nitpick comments LGTM.

composition/launch/composition_demo.launch Outdated Show resolved Hide resolved
composition/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll merged commit 48c28dd into master Apr 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the add_composition_launch branch April 24, 2019 23:45
@mjcarroll mjcarroll removed the in progress Actively being worked on (Kanban column) label Apr 24, 2019
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the convention is to use .launch.py as the extension.


def generate_launch_description():
"""Generate launch description with multiple components."""
launch_description = get_default_launch_description()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done for you automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants