Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter_blackboard to make some tutorials easier #333

Merged
merged 2 commits into from
May 10, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 10, 2019

Basically it is just a node that allows you to set parameters on it remotely or with the YAML file, without declaring them.

I plan to use it here:

https://index.ros.org/doc/ros2/Tutorials/Node-arguments/#parameters

Instead of talker.

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label May 10, 2019
@wjwwood wjwwood self-assigned this May 10, 2019
@dhood dhood added the in progress Actively being worked on (Kanban column) label May 10, 2019
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label May 10, 2019
@wjwwood
Copy link
Member Author

wjwwood commented May 10, 2019

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

demo_nodes_cpp/src/parameters/parameter_blackboard.cpp Outdated Show resolved Hide resolved
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood merged commit d7161d7 into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the parameter_blackboard branch May 10, 2019 17:53
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label May 10, 2019
@wjwwood
Copy link
Member Author

wjwwood commented May 10, 2019

I'm going to do another release of demos to get the binary out there since it is used by the tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants