Be explicit about reliability in Lifespan demos #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aults Signed-off-by: Emerson Knapp <eknapp@amazon.com>
jacobperron
approved these changes
May 23, 2019
| @@ -51,7 +52,10 @@ def main(args=None): | |||
|
|
|||
| qos_profile = QoSProfile( | |||
| depth=parsed_args.history, | |||
There was a problem hiding this comment.
Unrelated to this PR: I would recommend making arguments match the QoS setting for clarity. Briefly, this looked like a bug, assigning a history setting to a depth setting.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly specify Reliability policy in the Lifespan demos to be less dependent on defaults.
The Python version of this demo brought up the issue ros2/rclpy#353, which turned out to just be a difference in default settings between
rclcppandrclpy. The problem is fixed by making those defaults the same between clients (ros2/rclpy#356) and there is value in that use case, but there is a separate value in being explicit about the settings needed for this functionality to work as expected.Signed-off-by: Emerson Knapp eknapp@amazon.com