Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some demos handle SIGINT gracefully. #377

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jul 19, 2019

This pull request improves how some of our demos deal with interruptions. Connected to ros2/ros2cli#304.

@hidmic hidmic added this to In progress in Eloquent via automation Jul 19, 2019
Eloquent automation moved this from In progress to Reviewer approved Jul 19, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Oct 17, 2019

This one got lost in time. Rebased, merging after the Eloquent check's done.

@hidmic hidmic changed the title Make demos handle SIGINT gracefully. Make some demos handle SIGINT gracefully. Nov 19, 2019
@hidmic
Copy link
Contributor Author

hidmic commented Nov 19, 2019

@ros-pull-request-builder retest this please

@hidmic hidmic merged commit 6c4c631 into master Nov 19, 2019
Eloquent automation moved this from Reviewer approved to Done Nov 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/cli-test-coverage branch November 19, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Eloquent
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants