Add XML and YAML launch scripts for dummy_robot_bringup #440
Conversation
Signed-off-by: Pablo Vega <epvega@gmail.com>
| pkg: robot_state_publisher | ||
| exec: robot_state_publisher | ||
| output: screen | ||
| args: $(find-pkg-share dummy_robot_bringup)/launch/single_rrbot.urdf |
There was a problem hiding this comment.
@p-vega this form of robot_state_publisher configuration is deprecated -- use parameters instead of command line arguments, like in the XML.
There was a problem hiding this comment.
@hidmic Thanks for reviewing, I couldn't find any example of the proper parameter syntax for the yaml launch script. Can you point me in the right direction?
Use parameters instead of command line arguments for robot_state_publisher configuration Signed-off-by: Pablo Vega <epvega@gmail.com>
There was a problem hiding this comment.
LGTM
@jacobperron shall we merge this now or defer it till after Foxy?
| <launch> | ||
| <node pkg="dummy_map_server" exec="dummy_map_server" output="screen" /> | ||
| <node pkg="robot_state_publisher" exec="robot_state_publisher" output="screen" > | ||
| <param name='robot_description' value="$(command 'cat $(find-pkg-share dummy_robot_bringup)/launch/single_rrbot.urdf')"/> |
@hidmic I don't think we need to defer since this is a leaf package. |
… name Signed-off-by: Pablo Vega <epvega@gmail.com>
|
Alright, there're no tests covering this functionality so I don't think running CI's worth it. Merging. Thank you for your contribution @p-vega ! |
Add XML and YAML launch scripts for dummy_robot_bringup
Fixes #434
Signed-off-by: Pablo Vega epvega@gmail.com