Remove deprecated warning for rclcpp in clang builds

[piraka9011]

Signed-off-by: Anas Abou Allaban aabouallaban@pm.me

Resolve the following build warning for the nightly_linux_clang_libcxx build.

Can't seem to run CI for the clang build but can confirm local build passes with no warnings.

[clalancette]

I'm not sure why this isn't showing up on regular CI, but looks good to me. @piraka9011 Do you have the ability to run CI on this change?

[dirk-thomas]

I'm not sure why this isn't showing up on regular CI

Because the nightly_linux_clang_libcxx job is the only one using clang and libc++.

[clalancette]

Because the nightly_linux_clang_libcxx job is the only one using clang and libc++.

Yeah, but shouldn't the deprecation warning show up in gcc as well?

[dirk-thomas]

shouldn't the deprecation warning show up in gcc as well?

Should - but doesn't: ros2/rclcpp#1154.

[piraka9011]

Can't run CI for clang. I do have repos file you can use though.
https://gist.github.com/piraka9011/830e87d60cb5e36aa7b2d0744a642cf4

[dirk-thomas]

@piraka9011 Please do not manually trigger nightly jobs (https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/477/) - especially not with custom parameters. Only manually trigger the ci_* jobs.

[dirk-thomas]

Can't run CI for clang. I do have repos file you can use though.

• 
  • This reduces the compiler warnings by 1 compared to the latest nightly: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/476/

[dirk-thomas]

Thanks for the patch.

[ros-discourse]

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-07-16/15468/1