Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging macros #476

Merged
merged 4 commits into from
Dec 18, 2020
Merged

Update logging macros #476

merged 4 commits into from
Dec 18, 2020

Conversation

audrow
Copy link
Member

@audrow audrow commented Dec 11, 2020

This PR is part of ros2/rclcpp#1442.

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow audrow self-assigned this Dec 11, 2020
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@clalancette
Copy link
Contributor

(by the way, this is another one that I believe can go in without waiting for ros2/rclcpp#1442 ; the changes here should apply regardless of that PR)

@audrow
Copy link
Member Author

audrow commented Dec 18, 2020

Here's CI for ros2/rclcpp#1442, which includes this change:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow merged commit e47c82d into master Dec 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the audrow/update-logging branch December 18, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants