Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ineffective log output (#450) #477

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Remove ineffective log output (#450) #477

merged 1 commit into from
Dec 23, 2020

Conversation

y-okumura-isp
Copy link
Contributor

Signed-off-by: y-okumura-isp y-okumura@isp.co.jp

@y-okumura-isp
Remove ineffective log output (ros2#450)
1c3bc35 
Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
clalancette
clalancette approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. @y-okumura-isp Out of curiosity, what caused you to look at this? That is, what problem did you run into?

In any case, I'll run CI on this next.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit b133b05 into ros2:master Dec 23, 2020
@y-okumura-isp
Copy link
Contributor Author

@clalancette Thank you for review.

Out of curiosity, what caused you to look at this? That is, what problem did you run into?

We have interests in real-time, and started from pendulum_demo.
At first, we found reported stddev was wrong because of the following issue.
ros2/realtime_support#94
At the time, we created #450. (It was almost half year ago!)

You kindly gave us the advice, but we have had no time to work on it. Thank you very much.

@clalancette
Copy link
Contributor

@y-okumura-isp Thanks, I had totally forgotten about that! I'm going to go ahead and close that issue now, thanks!

@clalancette clalancette mentioned this pull request Dec 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y-okumura-isp @clalancette