Fix leak(#480) #481
Merged
Fix leak(#480) #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Jan 14, 2021
| @@ -32,7 +32,7 @@ int main(int argc, char * argv[]) | |||
| rclcpp::Logger logger = rclcpp::get_logger(LINKTIME_COMPOSITION_LOGGER_NAME); | |||
| rclcpp::executors::SingleThreadedExecutor exec; | |||
| rclcpp::NodeOptions options; | |||
| std::vector<class_loader::ClassLoader *> loaders; | |||
| std::vector<std::shared_ptr<class_loader::ClassLoader>> loaders; | |||
There was a problem hiding this comment.
Since there is only ever going to be one owner, I would suggest using a std::unique_ptr here.
Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
|
Thank you for comment. I updated PR. http://wiki.ros.org/class_loader may be the reason.
|
clalancette
approved these changes
Jan 19, 2021
|
CI:
|
|
Windows CI is failing for a completely unrelated reason. I think this is safe enough to put it without that, so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #480.
Although there are ASAN errors related to class_loader, this PR reduces one error.
Signed-off-by: y-okumura-isp y-okumura@isp.co.jp