Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter qos overrides in paramter events demos #491

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Filter qos overrides in paramter events demos #491

merged 3 commits into from
Mar 16, 2021

Conversation

ivanpauno
Copy link
Member

Fixes #490.

I did this because it was easier than fixing the text expectations, but doing the opposite might make more sense.

@ivanpauno
Filter qos overrides in parameter events demos
c6e2b25 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
add comment
2d2d099 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the bug Something isn't working label Mar 15, 2021
@ivanpauno ivanpauno self-assigned this Mar 15, 2021
@ivanpauno ivanpauno mentioned this pull request Mar 16, 2021
Closed
@ivanpauno
Copy link
Member Author

I'm not sure why the PR checker is failing, but it's not related to this PR.

@mjcarroll
Copy link
Member

Running CI with Connext:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
fix failure
c849168 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mjcarroll
mjcarroll approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, arm64 is expected due to lack of connext there?

@mjcarroll
Copy link
Member

The Rpr failure seems to be cyclonedds related, so nothing to do with this PR

RuntimeError: Failed to initialize init_options: failed to load shared library 'librmw_cyclonedds_cpp.so' due to dlopen error: librmw_cyclonedds_cpp.so: cannot open shared object file: No such file or directory, at /tmp/binarydeb/ros-rolling-rcutils-3.1.0/src/shared_library.c:97, at /tmp/binarydeb/ros-rolling-rmw-implementation-2.2.0/src/functions.cpp:74, at /tmp/binarydeb/ros-rolling-rcl-2.5.2/src/rcl/init_options.c:75

@mjcarroll mjcarroll merged commit 430a762 into master Mar 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/filter-qos-overrides-in-paramter-events-demos branch March 16, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@ivanpauno ivanpauno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Regression: test_tutorial_parameter_events
2 participants
@ivanpauno @mjcarroll