Fix integer type in RCLCPP_* macro printf. #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While building on macOS, a warning shows up like: format specifies type 'long' but the argument has type 'int64_t' (aka 'long long') The problem is that %ld isn't correct for int64_t on all platforms. Switch to the PRId64 macro so the type is correct everywhere. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
mjeronimo
approved these changes
Mar 29, 2021
|
The failure on Windows is not because of this PR. The failure on PR jobs seems to be a long-standing issue. I'm going to go ahead and merge this, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building on macOS, a warning shows up like:
format specifies type 'long' but the argument has type 'int64_t' (aka 'long long')
The problem is that %ld isn't correct for int64_t on all
platforms. Switch to the PRId64 macro so the type is correct
everywhere.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org