-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sizeof(char) in place for sizeof(void) #515
Conversation
The latter is invalid C++, even though gcc accepts it as an extension Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
I'm not against making this change, but this can't just be a GCC extension, right? This same code is compiling with clang and MSVC as well. |
Yeah, I dunno, There is a specialization for |
This seems to be a broadly accepted extension 😂. But AFAIU it's not supposed to be correct.
|
FWIW, besides |
This reverts commit c3769dd. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
The latter is invalid C++, even though gcc accepts it as an extension. Connected to ros2/rclcpp#1647.
CI up to
rclcpp
anddemo_nodes_cpp
: