Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of future in lifecycle demo #534

Merged
merged 2 commits into from Oct 3, 2021
Merged

Fix use of future in lifecycle demo #534

merged 2 commits into from Oct 3, 2021

Conversation

christophebedard
Copy link
Member

Fixes #533

See #533 (comment)

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

@christophebedard
Fix use of future in lifecycle demo
174d365 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Fix other instance
edd8e2e 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
clalancette
clalancette approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@christophebedard
Copy link
Member Author

Just for lifecycle:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

I think Windows CI is broken: https://ci.ros2.org/view/nightly/

@clalancette
Copy link
Contributor

I think Windows CI is broken: https://ci.ros2.org/view/nightly/

Yeah, it is. We're investigating.

@christophebedard
Copy link
Member Author

Re-build of the Windows job:

  • Windows Build Status

@clalancette
Copy link
Contributor

Looks good to me, thanks for re-running Windows CI. Merging.

@clalancette clalancette merged commit 85c3ed0 into ros2:master Oct 3, 2021
@christophebedard christophebedard deleted the fix-lifecycle-demo-future branch October 3, 2021 23:07
@Blast545
Copy link

Blast545 commented Oct 4, 2021

👨‍🌾 I think this introduced 2 test regressions in the Windows debug nightlies. Can I ask you to take a look into this? @christophebedard

@christophebedard
Copy link
Member Author

christophebedard commented Oct 5, 2021 •
edited

man_farmer I think this introduced 2 test regressions in the Windows debug nightlies. Can I ask you to take a look into this? @christophebedard

I looked into it and I don't see how the set_param_launch_test and talker_listener_launch_test failures are related to this PR. They don't use the nodes from this lifecycle demo; they use their own nodes for tests.

@Blast545
Copy link

Blast545 commented Oct 5, 2021

Alright, thanks for taking a look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle demo is broken
3 participants
@christophebedard @clalancette @Blast545