Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for pendulum_control. #537

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

clalancette
Copy link
Contributor

This fixes several minor issues pointed out by rosdoc2 when
building the documentation for pendulum_control.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This fixes several minor issues pointed out by rosdoc2 when
building the documentation for pendulum_control.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a few nits.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

Since there is actual code change in this PR (the change from PI to M_PI, in particular), I'm going to run CI on it on all platforms.

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor Author

I'm going to go ahead and merge this one with green CI and an approval, thanks for the review!

@clalancette clalancette merged commit 0cfdbe9 into master Nov 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-pendulum-control-docs branch November 4, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants