Additional fixes for documentation in demos. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these fixes, I think we should get a green Rdoc build. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
hidmic
reviewed
Nov 8, 2021
quality_of_service_demo/rclcpp/include/quality_of_service_demo/common_nodes.hpp
Outdated
Show resolved
Hide resolved
quality_of_service_demo/rclcpp/include/quality_of_service_demo/common_nodes.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
hidmic
approved these changes
Nov 9, 2021
|
The yellow Windows build is unfortunate, but I have a hard time seeing how they could be related to this PR. The failures are all in either I'm going to go ahead and assume they are unrelated failures and merge. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these fixes, I think we should get a green Rdoc build.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org