Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add how to fix the most vexing parse problem #541

Merged
merged 3 commits into from Nov 11, 2021
Merged

Add how to fix the most vexing parse problem #541

merged 3 commits into from Nov 11, 2021

Conversation

fujitatomoya
Copy link
Collaborator

address #540

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

@fujitatomoya
Add how to fix the most vexing parse problem
8e159f4 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@clalancette
Copy link
Contributor

Can I suggest uniform initialization instead? It's more straightforward, and we required C++14 (for Foxy) or C++17 (for Galactic and Rolling).

I'd still keep the comment, though updated to explain why uniform initialization must be used here.

@fujitatomoya
Copy link
Collaborator Author

@clalancette sounds good to me, thanks for checking!

@fujitatomoya
use uniform initialization instead of extra pair of parentheses
cbb53b2 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette
clalancette requested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small item to fix in the comments, then I think this is good to go.

That said, I'm curious why rclcpp::QoS qos(rclcpp::KeepAll()); fails to compile. Naively, I expect it would. Should we file a bug in rclcpp to follow-up and fix that?

demo_nodes_cpp/src/topics/talker.cpp Outdated Show resolved Hide resolved
@fujitatomoya
fix comment
8e36987 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette
clalancette approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me with green CI.

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Nov 10, 2021 •
edited

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

all green, going in.

@fujitatomoya
Copy link
Collaborator Author

Ah, i do not have access on this repo 😢 @clalancette could you do me a favor? thanks 😄

@clalancette clalancette merged commit 965036f into ros2:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fujitatomoya @clalancette