Adds copy constructor and assignment operator to ROSCvMatContainer #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
Otherwise we get bogus data in the destination sometimes. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
gonzodepedro/added-copy-constructor
branch
from
a44544f
to
10d1855
Compare
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
clalancette
force-pushed
the
gonzodepedro/added-copy-constructor
branch
from
10d1855
to
85ac31c
Compare
|
As context, we'll need this in place in order for ros2/rclcpp#1849 to successfully compile and run. |
|
CI:
|
clalancette
approved these changes
Dec 21, 2021
|
Two approvals, and CI is green, so going ahead and merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.