Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of OpenCV libraries image_tools links against. #549

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

clalancette
Copy link
Contributor

By using the OpenCV components, we only pull in the parts we
need, slightly speeding things up. While we are in here, we
also only include the headers we need, and use the "newer"
name of the headers instead of the legacy ones.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

By using the OpenCV components, we only pull in the parts we
need, slightly speeding things up.  While we are in here, we
also only include the headers we need, and use the "newer"
name of the headers instead of the legacy ones.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

clalancette commented Jan 5, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@clalancette
Copy link
Contributor Author

CI is green, and approved, so merging.

@clalancette clalancette merged commit b675cff into master Jan 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/reduce-opencv-libs branch January 6, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants