Switch to using RCLCPP logging macros in the lifecycle package. #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the logging will go out to rosout and to disk (if configured like that). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
|
CI:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
iuhilnehc-ynos
approved these changes
Jul 19, 2023
| @@ -23,22 +23,22 @@ add_executable(lifecycle_talker | |||
| src/lifecycle_talker.cpp) | |||
| ament_target_dependencies(lifecycle_talker | |||
| "lifecycle_msgs" | |||
| "rclcpp" | |||
There was a problem hiding this comment.
The CMakeLists.txt in rclcpp_lifecycle export the dependencies for rclcpp, it seems unnecessary to add rclcpp here.
Of course, adding rclcpp explicitly is also correct.
| "rclcpp_lifecycle" | ||
| "std_msgs" | ||
| ) | ||
| add_executable(lifecycle_listener | ||
| src/lifecycle_listener.cpp) | ||
| ament_target_dependencies(lifecycle_listener | ||
| "lifecycle_msgs" | ||
| "rclcpp_lifecycle" | ||
| "rclcpp" |
There was a problem hiding this comment.
👍 , lifecycle_listener.cpp just used the rclcpp component.
|
CI:
|
clalancette
referenced
this pull request
Jul 19, 2023
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
delete-merged-branch
bot
deleted the
clalancette/use-rclcpp-logging-macros
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the logging will go out to rosout and to disk (if configured like that).