Add in support for both the PMR and custom allocator tutorials. #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly because libc++ 14 (in Ubuntu 22.04) only understands the old version. So we choose the appropriate file based on the compiler in use. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
adityapande-1995
approved these changes
Oct 16, 2023
|
CI:
|
|
Oh, and clang:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly because libc++ 14 (in Ubuntu 22.04) only understands the old version. So we choose the appropriate file based on the compiler in use.
Note that this partially undoes #653 , at least by adding in both versions, and then selecting at compile-time. This should fix our failing Clang builds at https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/