Various fixes

[mikaelarguedas]

• Install lifecycle demo executables to libexec (fixes move lifecycle executables in package specific path #137 )
• install dummy robot/* executables to libexec
• make launchfiles runnable with launch (fixes dummy_robot_bringup launch file fails when started with launch #140 )
• install topic monitor executables to libexec (fixes move topic_monitor executables in package specific path #138 )
• switch talker/listener_qos to use the chatter topic (fixes [demo_nodes_py] talker_qos and talker don't use the same topic name #144 )

Not in this PR:

• move the pendulum demo executables (because they need to be on the path given the current launch logic)

Depends on ros2/robot_state_publisher#8
Depends on ros2/ros2cli#23

[mikaelarguedas]

if we dont want to address "make topic_monitor launchfiles runnable with launch" this is ready for review

[wjwwood]

lgtm, but I don't know how to answer the question about topic_monitor needing to be launch-able by launch.

[dhood]

sorry, didn't see the 'question' because updating the description doesn't send notifications (nor does editing in an @-mention). This looks good as is and I'll have a look at the topic monitor launching

[mikaelarguedas]

sounds good, thank you both for the the input

[mikaelarguedas]

waiting for ros2/ros2cli#23 to be resolved to update this before merging

[mikaelarguedas]

ok I think this is ready for another review (sorry I rebased so it's not easy to see identify new commits since the last review). I'll wait for ros2/ros2cli#23 to be merged and then merge this along updating all the tutorials accordingly

@dhood I updated the topic_monitor README to match the current state, I'll leave it to you to update anything necessary if you decide to iterate on the launchfiles 😉

[dirk-thomas]

This might need to be updated when ament/ament_python#2 is merged to use the same approach as in the referenced PRs.

[mikaelarguedas]

thanks @dhood for the review and fixes!

[dirk-thomas]

This previous comment still needs to be addressed. Otherwise the moved executables aren't runnable with ros2 run.

[mikaelarguedas]

Yeah I fell asleep before opening a PR. I'll do that this morning