Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spin_until_future_complete instead of spin_some in parameters_event demo #427

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Use spin_until_future_complete instead of spin_some in parameters_event demo #427

merged 3 commits into from
Jan 30, 2020

Commits on Jan 29, 2020

  1. Fix parameter event demo 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    47ec7fe View commit details
    Browse the repository at this point in the history

  2. Address peer review comments 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    59ddb50 View commit details
    Browse the repository at this point in the history

  3. Correct linter failures 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    ea08356 View commit details
    Browse the repository at this point in the history