Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_tools] Update ROSCVMatContainer and do not convert color space of frames #623

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

Yadunund
Copy link
Member

Fix #612

This PR

  • Updates the ROSCvMatContainer to allow users to specify and override of the encoding string passed to sensor_msgs::Image. This is mostly for accurate visualization with rviz. Also updates cam2image appropriately.
  • Updates showimage to not perform any color space conversions to the frame. This is the actual fix to the issue

TODO: Test with hardware, remove comments and update tutorial doc

…cv frame color conversions

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGB order flipped when using cam2image with showimage
1 participant