Install CLI parsing header #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rpr is failing after a change in rclcpp upstream. |
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
rebecca-butler
force-pushed
the
install-cli-header
branch
from
3fa03cf
to
3ef4958
Compare
jacobperron
pushed a commit
that referenced
this pull request
Oct 21, 2021
* Remove process_cmd_line_args() from detail namespace Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Add docstrings Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Move process_cmd_line_arguments.hpp to include directory Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Fix includes Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Merged
jacobperron
pushed a commit
that referenced
this pull request
Oct 21, 2021
* Remove process_cmd_line_args() from detail namespace Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Add docstrings Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Move process_cmd_line_arguments.hpp to include directory Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Fix includes Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
jacobperron
pushed a commit
that referenced
this pull request
Oct 21, 2021
* Remove process_cmd_line_args() from detail namespace Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Add docstrings Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Move process_cmd_line_arguments.hpp to include directory Signed-off-by: Rebecca Butler <rebecca@openrobotics.org> * Fix includes Signed-off-by: Rebecca Butler <rebecca@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
process_cmd_line_arguments.hppto the include directory, and removes the public API from the detail namespace.