Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override handle_serialized_message. #21

Merged
merged 2 commits into from May 19, 2021
Merged

Override handle_serialized_message. #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b05b91
Override handle_serialized_message.
clalancette May 19, 2021
eaef447
Remove the override flag with a note explaining why.
clalancette May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/domain_bridge/generic_subscription.cpp
View file
Open in desktop
Expand Up @@ -79,6 +79,14 @@ void GenericSubscription::handle_loaned_message(
(void) message_info;
}

void GenericSubscription::handle_serialized_message(
const std::shared_ptr<rclcpp::SerializedMessage> & serialized_message,
const rclcpp::MessageInfo & message_info)
{
(void) serialized_message;
(void) message_info;
}

void GenericSubscription::return_message(std::shared_ptr<void> & message)
{
auto typed_message = std::static_pointer_cast<rclcpp::SerializedMessage>(message);
Expand Down
5 changes: 5 additions & 0 deletions src/domain_bridge/generic_subscription.hpp
View file
Open in desktop
Expand Up @@ -69,6 +69,11 @@ class GenericSubscription : public rclcpp::SubscriptionBase
void handle_loaned_message(
void * loaned_message, const rclcpp::MessageInfo & message_info) override;

void
handle_serialized_message(
const std::shared_ptr<rclcpp::SerializedMessage> & serialized_message,
const rclcpp::MessageInfo & message_info) override;
jacobperron marked this conversation as resolved.
Show resolved Hide resolved

// Same as return_serialized_message() as the subscription is to serialized_messages only
void return_message(std::shared_ptr<void> & message) override;

Expand Down