Add Fibonacci.action #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added mapping rules for the Fibonacci action from ROS 1.
jacobperron
added
in progress
sloretz
reviewed
Nov 21, 2018
| ros1_package_name: 'actionlib_tutorials' | ||
| ros1_action_name: 'Fibonacci' | ||
| ros2_package_name: 'example_interfaces' | ||
| ros2_action_name: 'Fibonacci' |
There was a problem hiding this comment.
Is the bridge OK with ros2_action_name in the rules?
There was a problem hiding this comment.
Honestly, I have no idea. I wrote this a while ago as part of the design doc/examples proposal. I suspect this will need to change.
|
sloretz
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to ros2/examples#216
This defines the action used in the examples packages.