Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter example #164

Closed
geoffviola opened this issue Jan 4, 2017 · 3 comments · Fixed by ros2/demos#273
Closed

Add a parameter example #164

geoffviola opened this issue Jan 4, 2017 · 3 comments · Fixed by ros2/demos#273
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@geoffviola
Copy link

It would be nice, if there was an example that uses the parameter service and follows the best practices from https://discourse.ros.org/t/composition-and-parameters-best-practice-suggestions/1001/2. Then, it can be tested with the ros2param tool.

@dirk-thomas dirk-thomas added the enhancement New feature or request label Jan 4, 2017
@wjwwood
Copy link
Member

wjwwood commented Jan 4, 2017

Yeah, we didn't get time to update things here, but in the meantime you can see "non-composition" examples that used to be here in the demos repository:

https://github.com/ros2/demos/tree/master/demo_nodes_cpp/src/parameters

@geoffviola
Copy link
Author

Thanks, but none of those examples use the register_param_change_callback node method from https://github.com/ros2/rclcpp/blob/master/rclcpp/include/rclcpp/node.hpp#L268. Those nodes setup their own server and client, which is the less desirable way to parameters.

@wjwwood
Copy link
Member

wjwwood commented Jan 4, 2017

Ah, yeah that's true.

@mikaelarguedas mikaelarguedas added the help wanted Extra attention is needed label Feb 22, 2018
@mikaelarguedas mikaelarguedas added this to the bouncy milestone Feb 22, 2018
@mikaelarguedas mikaelarguedas removed this from the bouncy milestone May 7, 2018
@mikaelarguedas mikaelarguedas self-assigned this Aug 2, 2018
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 2, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants