Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #include <chrono> if using std::chrono_literals #198

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Add #include <chrono> if using std::chrono_literals #198

merged 1 commit into from
Dec 22, 2017

Conversation

youtalk
Copy link
Contributor

@youtalk youtalk commented Dec 17, 2017

According to #197 (comment), this PR adds #include <chrono> if the script file use std::chrono_literals.

mikaelarguedas
mikaelarguedas approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution

@mikaelarguedas
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Dec 22, 2017
@mikaelarguedas mikaelarguedas merged commit a75151e into ros2:master Dec 22, 2017
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Dec 22, 2017
@youtalk youtalk deleted the include-chrono-if-using-chrono-literals branch December 22, 2017 05:40
@youtalk
Copy link
Contributor Author

youtalk commented Dec 22, 2017

@mikaelarguedas Thank you for review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youtalk @mikaelarguedas