Use std::chrono_literals only #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
previously requested changes
Dec 17, 2017
| @@ -12,18 +12,18 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| #include <chrono> | |||
|
|
|||
There was a problem hiding this comment.
Since the code is using std::chrono_literals it needs to keep this include.
There was a problem hiding this comment.
@dirk-thomas Thank you for reviewing. I've reverted it.
Because other cpp files don't also include it, I remove it.
This reverts commit 308f2f3.
|
Thank you for the patch.
Everything a source file uses should be explicitly included since the source file can't assume that other header don't change in the future and might remove the transitive dependency. |
|
That sounds good. I'll make another PR to make it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All examples in
rclcppdirectory usestd::chrono_literalsexcept inpublisher_node.cpp.This PR changes to use
500msinstead ofstd::chrono::milliseconds(500)usingstd::chrono_literalssuch as the other examples.