Refactor WaitForNodes class. #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal here is to get rid of the sometimes flaky tests we are seeing in the nightlies. To do that, we try increasing the default timeout from 10 to 15 seconds. While we are in here, do a few other pieces of refactoring in this test: 1. Use a common variable name for the node name. 2. Switch the variable name for the loop to 'finished', which better reflects what it is doing. 3. Change the sleep between loops to 0.1, so we react faster 4. Remove the unnecessary _prepare_node() method. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
approved these changes
Mar 5, 2024
delete-merged-branch
bot
deleted the
clalancette/launch-testing-examples-refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to get rid of the sometimes
flaky tests we are seeing in the nightlies. To do that, we try increasing the default timeout from 10 to 15 seconds.
While we are in here, do a few other pieces of refactoring in this test:
I think this should make the flaky test as in https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2978/testReport/junit/launch_testing_examples.launch_testing_examples/check_multiple_nodes_launch_test/launch_testing_examples_check_multiple_nodes_launch_test/ less flaky.