Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when exiting scripts #175

Merged
merged 1 commit into from
Jun 27, 2017
Merged

fix error when exiting scripts #175

merged 1 commit into from
Jun 27, 2017

Conversation

dirk-thomas
Copy link
Member

Fixes an error with rmw_connext_cpp when existing the async scripts. Updated the sync script to match the same behavior.

I didn't run any CI builds since this isn't covered anyway.

Ready for review.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 27, 2017
@dirk-thomas dirk-thomas self-assigned this Jun 27, 2017
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirk-thomas dirk-thomas merged commit dfde38a into master Jun 27, 2017
@dirk-thomas dirk-thomas deleted the fix_error_on_exit branch June 27, 2017 23:21
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants