-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_two_ints_client doesn't respond in python on Windows #97
Comments
Note that I believe the tracebacks on shutdown are related to #95 so not exploring here. |
This also effects
|
The error you see on shutdown looks more like ros2/examples#175. Please try the same patch here. |
I can't reproduce with the latest packaging job. I'm going to try a source
build next.
…On Wed, Jun 28, 2017 at 7:07 PM, Dirk Thomas ***@***.***> wrote:
Note that I believe the tracebacks on shutdown are related to #95
<#95> so not exploring here.
The error you see on shutdown looks more like ros2/examples#175
<ros2/examples#175>. Please try the same patch
here.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#97 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGkvHyCAPWrCr33a9XWUe94PIO3dSqTyks5sIwbOgaJpZM4OIu3e>
.
--
Adam
|
I tried to run the executables you mentioned ( Please try to reproduce the problem from a fresh build and provide more information. |
With a pull and rebuild this morning I cannot reproduce. @Kukanani If you can't reproduce either please close. |
Since we already have three "not reproducible" responses I will close this directly. |
I've done quite a bit more debugging on this. It appears to be the cross platform support. How much do we want to try to work on this for the beta? The only major issue within a platform is RTI python server - python client RTI cpp add_two_ints_serverhttps://gist.github.com/tfoote/3ed7f4781b986c1a663b0233c41e7c96 RTI service call works FRTPS service call works ~3 of 5 times RTI py add_two_ints serverhttps://gist.github.com/tfoote/aecc5cbd359c5a839d5e317b94b212c5 FRTPS service call 50% RTI service call works relatively well (maybe missing wait for service/retry) Other...RTI Python server quit after 2 rounds on RTI cpp client and FastRTPS cpp client https://gist.github.com/tfoote/aecc5cbd359c5a839d5e317b94b212c5#file-fastrtps-cpp-client-server-oddity FRTPS cpp serverhttps://gist.github.com/tfoote/5810bbc1a4f88f14cda29cd8094405b1 FRTPS service call good RTI service call nothing FRTPS py serverhttps://gist.github.com/tfoote/9145d1285e3a9a9f36b15f9228ed2ecd FRTPS service call good RTI service call (request goes through, but reply doesn't come back) |
The right term for this testing is "cross vendor". "Cross platform" refers to e.g. testing a server on Linux using a client on Windows. The gist output contains the following two pieces repeatedly:
Are you sure that you are using the latest version for testing? The first one is behavior which was changed recently to only request once. Also (some of) the exit problems have been fixed in the last days. Can you please compare the exact hashes of your code with the latest default branches and make sure that you have rebuild everything cleanly. |
The instructions at https://github.com/ros2/ros2/wiki/Maintaining-a-Source-Checkout didn't have |
I tested this with a fresh build (same VM as @tfoote ) Fastrtps every combination of server and client (cpp/python) works fine
So it looks to be an issue with the Python client on connext |
This looked to be a timing issue related to machine performance that's why it was showing up only in the VMs. Sleep time is arbitrary though so this is a temporary fix, we need a Python version of "wait_for_service" to actually fix the issue |
It hangs when run against either server.
![add_two_ints_failing_fastrtps](https://user-images.githubusercontent.com/447804/27667812-27f73d68-5c32-11e7-97e2-a0e05e051b16.gif)
This example is fastrtps but I see the same issue for Connext.
Async_client doesn't quite finish when running against the python server
![async_python_client](https://user-images.githubusercontent.com/447804/27667785-06c00d0a-5c32-11e7-9d8d-bc9cd51064ab.png)
The text was updated successfully, but these errors were encountered: