Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final batch of examples #327
Final batch of examples #327
Changes from 9 commits
45d0fd3
41a80a5
ad73723
15f26e3
4c3f958
5d7b82c
73f3eb6
ce92035
40d4a68
9a0f7af
46aea7d
c547867
89c6ce3
fbe86a1
fb8ee51
aeae1e9
832706f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a potential gap in launch_testing. It would be nice if there was a launch_testing feature that could delay the shutdown event. I know there is a
KeepAlive
action, but I don't know if that is exactly what we want here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just add a
Timer
action in the launch description with a 3s period that does nothing.That will keep the launch service alive and delay the shutdown.
It's still kind of a hack though.