Porting test_tf2 #203
Merged
Porting test_tf2 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
reviewed
Dec 17, 2019
ahcorde
force-pushed
the
ahcorde/test/test_tf2
branch
from
5f382d3
to
7e5d582
Compare
…/test/test_tf2
ahcorde
force-pushed
the
ahcorde/test/test_tf2
branch
from
9ceb430
to
740a310
Compare
|
|
|
@clalancette finally CI is green. We can merge #217 and #216 too All this 3 PR are included and tested in this branch https://github.com/ros2/geometry2/tree/ahcorde/test/test_tf2_msg_filter_fix2 |
clalancette
reviewed
Jan 17, 2020
|
|
||
| */ | ||
|
|
||
| // /* |
There was a problem hiding this comment.
This comment is still open.
test_tf2/test/buffer_core_test.cpp
Outdated
| } | ||
|
|
||
| // rclcpp::shutdown(); |
There was a problem hiding this comment.
This comment is still open.
test_tf2/test/buffer_core_test.cpp
Outdated
| { | ||
| //printf("source_frame %s target_frame %s time %f\n", source_frame.c_str(), target_frame.c_str(), eval_time.toSec()); | ||
| //printf("source_frame %s target_frame %s time %f\n", source_frame.c_str(), target_frame.c_str(), eval_time.toSec()); |
There was a problem hiding this comment.
I think we should just remove this commented-out code.
test_tf2/test/buffer_core_test.cpp
Outdated
| { | ||
| //printf("source_frame %s target_frame %s time %f\n", source_frame.c_str(), target_frame.c_str(), eval_time.toSec()); | ||
| //printf("source_frame %s target_frame %s time %f\n", source_frame.c_str(), target_frame.c_str(), eval_time.toSec()); |
There was a problem hiding this comment.
Remove this commented out code.
test_tf2/test/buffer_core_test.cpp
Outdated
| { | ||
| //printf("source_frame %s target_frame %s time %f\n", source_frame.c_str(), target_frame.c_str(), eval_time.toSec()); | ||
| //printf("source_frame %s target_frame %s time %f\n", source_frame.c_str(), target_frame.c_str(), eval_time.toSec()); |
There was a problem hiding this comment.
Remove this commented out code.
test_tf2/test/buffer_core_test.cpp
Outdated
| @@ -2809,7 +2868,7 @@ TEST(tf2_stamped, OperatorEqual) | |||
| */ | |||
| int main(int argc, char **argv){ | |||
| testing::InitGoogleTest(&argc, argv); | |||
| builtin_interfaces::msg::Time::init(); //needed for builtin_interfaces::msg::Time::now() | |||
| ros::init(argc, argv, "tf_unittest"); | |||
| // builtin_interfaces::msg::Time::init(); //needed for builtin_interfaces::msg::Time::now() | |||
There was a problem hiding this comment.
Remove commented-out code.
test_tf2/test/permuter.hpp
Outdated
Comment on lines
36
to
37
| #include <vector> | ||
| #include <mutex> |
test_tf2/test/test_buffer_client.cpp
Outdated
Comment on lines
43
to
46
| #include <chrono> | ||
| #include <thread> | ||
| #include <functional> | ||
| #include <memory> |
Comment on lines
41
to
42
| #include <memory> | ||
| #include <functional> |
| }; | ||
|
|
||
| TEST(StaticTransformPublisher, tf_from_param_server_valid) | ||
| // TODO (ahcorde) Load transform from yaml |
There was a problem hiding this comment.
Can you expand a bit on what needs to be done to port this test?
|
Closed
|
The code changes now look good to me. Do you know what is going on with the test failure in CI? |
|
clalancette
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial port for the package test_tf2