Porting tf2_bullet to ros2 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
approved these changes
Dec 17, 2019
|
ahcorde
commented
Dec 19, 2019
tf2_bullet/package.xml
Outdated
| @@ -21,5 +21,10 @@ | |||
| <run_depend>bullet</run_depend> | |||
| <run_depend>geometry_msgs</run_depend> | |||
|
|
|||
| </package> | |||
| <depend>bullet</depend> | |||
There was a problem hiding this comment.
I have include this line for rosdep. But it's not working, "bullet" is still not installed
There was a problem hiding this comment.
Yeah. This makes it work with rosdep and the buildfarm, so it is necessary. Unfortunately the CI system doesn't use rosdep to calculate this stuff, so we still have to modify the CI scripts to install it manually. There are a few steps to getting this in:
- Figure out a way to install bullet on Windows. Ideally this would be a chocolatey package.
- If a chocolatey package is available, edit https://github.com/ros2/ros2_documentation/blob/master/source/Installation/Foxy/Windows-Development-Setup.rst to add it. Also log into each of the CI Windows machines and install it.
- If a chocolatey package is not available there are 2 options: build and host a chocolatey package ourselves (we have done this for some dependencies), or vendor bullet (this is more common). One example of a vendored package is https://github.com/ros2/yaml_cpp_vendor; that can be used as a template.
- Add libbullet-dev to https://github.com/ros2/ci/blob/25a3bdf20a310b1df8b28a5af92e1eb66d5681ea/linux_docker_resources/Dockerfile#L40 (that will fix it for Linux).
- Edit https://github.com/ros2/ros2_documentation/blob/master/source/Installation/Foxy/OSX-Development-Setup.rst , add a line to
brew install bullet. - Log into each of the CI machines and run
brew install bullet.
In this case the most important thing to figure out is how we are going to deal with it for Windows, since I think it is pretty straightforward for both Linux and macOS. Once we have that figured out the rest is just work that needs to get done.
This was referenced Dec 19, 2019
Merged
This was referenced Dec 20, 2019
Signed-off-by: ahcorde <ahcorde@gmail.com>
…etry2 into ahcorde/pkg/tf2_bullet
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting tf2_bullet to ros2
I need this package to continue porting
test_tf2