Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing visibility header include #246

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

jacobperron
Copy link
Member

Noticed this was missing when trying to compile an external project including this header.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the bug Something isn't working label Mar 25, 2020
@jacobperron jacobperron self-assigned this Mar 25, 2020
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@tfoote tfoote merged commit 6788c1b into ros2 Mar 26, 2020
@tfoote tfoote deleted the jacob/missing_visibility_header branch March 26, 2020 22:31
jacobperron added a commit that referenced this pull request Dec 1, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron moved this from Proposed to Needs Backport in Eloquent Patch Release 2 Dec 1, 2020
jacobperron added a commit that referenced this pull request Dec 1, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants