fix test_static_publisher in macos #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
|
Please use the ROS 2 style for newly written code (spaces between |
Signed-off-by: ahcorde <ahcorde@gmail.com>
dirk-thomas
approved these changes
Jul 1, 2020
jacobperron
pushed a commit
that referenced
this pull request
Jul 22, 2020
* Attempt to fix test_static_publisher in macos Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
|
I believe we're seeing the same flaky failure on Foxy dev jobs, for example. I've opened a backport PR for Foxy: #287 |
jacobperron
added a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with the fail in the macos CI https://ci.ros2.org/view/nightly/job/nightly_osx_extra_rmw_release/lastBuild/testReport/junit/(root)/projectroot/test_static_publisher_launch_py/
Signed-off-by: ahcorde ahcorde@gmail.com