Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait time option to view_frames #374

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

jacobperron
Copy link
Member

Sometimes the default 5 seconds is not enough time to collect all TF
data. The new command-line option let's the user change the time to
wait when collecting TF frame information from the system.

Sometimes the default 5 seconds is not enough time to collect all TF
data. The new command-line option let's the user change the time to
wait when collecting TF frame information from the system.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the enhancement New feature or request label Feb 5, 2021
@jacobperron jacobperron self-assigned this Feb 5, 2021
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we neeed to include python3-argparse as a <exec_depend> in the package.xml ?

@clalancette
Copy link
Contributor

Do we neeed to include python3-argparse as a <exec_depend> in the package.xml ?

It shouldn't be necessary; argparse is builtin in python3 (as far as I know).

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@jacobperron
Copy link
Member Author

Do we neeed to include python3-argparse as a <exec_depend> in the package.xml ?

It shouldn't be necessary; argparse is builtin in python3 (as far as I know).

Yeah, I don't think it is necessary. I don't see any of our other packages declaring a dependency on argparse.

@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 40ea54d into ros2 Feb 10, 2021
@jacobperron jacobperron deleted the jacob/view_frames_wait_time_opt branch February 10, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants