Allow to reconfigure durability for /tf topic broadcaster/listener

[ivanpauno]

Follow up of #381.

Allows reconfiguring the durability qos setting for /tf broadcaster/listener.
This wasn't applied to /tf_static, as in that case durability must always be transient local.

[jacobperron]

LGTM, but I'd like a second opinion.

[ivanpauno]

@clalancette could you take a look to this? do you think splitting the old options argument in options and static_options is fine?

[clalancette]

The idea here seems fine to me; we split the /tf and /tf_static, so having them have different options and overrides make sense.

I can't say I love the implementation. In particular, void init() is a private method, so there is no real reason for it to have overridable default arguments. I'd just move the code that creates the options and static_options into the body of init(), and simplify the signature.

[ivanpauno]

The idea here seems fine to me; we split the /tf and /tf_static, so having them have different options and overrides make sense.

I can't say I love the implementation. In particular, void init() is a private method, so there is no real reason for it to have overridable default arguments. I'd just move the code that creates the options and static_options into the body of init(), and simplify the signature.

Good point! I didn't notice that it was a private method

[ivanpauno]

I can't say I love the implementation. In particular, void init() is a private method, so there is no real reason for it to have overridable default arguments. I'd just move the code that creates the options and static_options into the body of init(), and simplify the signature.

Actually, I need the defaults in the constructor and not only in init().
See 0ec7e9e.

[clalancette]

Looks good to me with green CI! Thanks for iterating.

[ivanpauno]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows