Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer_client.py using default timeout_padding #437

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Fix buffer_client.py using default timeout_padding #437

merged 2 commits into from
Jul 8, 2021

Conversation

charlielito
Copy link
Contributor

fixes #436

charlielito and others added 2 commits July 7, 2021 12:13
@charlielito
Fix buffer_client.py using default timeout_padding
c5b523f 
fixes ros2#436
@clalancette
Cleanup the constructor documentation.
a33714e 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
clalancette approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I ended up doing a slight bit more cleanup in here to the documentation. This looks good to me, so I'll approve and run CI on it now.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 141e3cb into ros2:ros2 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using tf2_ros.buffer_client.BufferClient with default arguments crashes
2 participants
@charlielito @clalancette