Export a tf2_bullet::tf2_bullet target #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
|
CI (build:
|
sloretz
commented
Jan 8, 2022
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
|
CI again now that Windows CI should be using the latest bullet version
|
|
Windows CMake warning is also on the nightly: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2256/cmake/new/ so CI LGTM! |
gbiggs
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #493
This makes tf2_bullet use more modern CMake. It now exports a
tf2_bullet::tf2_bullettarget, avoidsament_target_dependencies()(ament/ament_cmake#292), and wraps the use ofBULLET_INCLUDE_DIRSandBULLET_LIBRARIESwith atf2_bullet::Bullettarget.Requires ros2/choco-packages#18
Requires ros-infrastructure/ros2-cookbooks#42