Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpplint errors #497

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix cpplint errors #497

merged 2 commits into from
Jan 12, 2022

Conversation

jacobperron
Copy link
Member

@jacobperron
Fix include order for cpplint
bb6fde3 
Relates to ament/ament_lint#324

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Replace C-style cast with static_cast
7c7eae0 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
clalancette
clalancette reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but the Rpr job is cranky about it.

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

1 similar comment
@clalancette
Copy link
Contributor

@ros-pull-request-builder retest this please

@jacobperron jacobperron mentioned this pull request Jan 11, 2022
Merged
@jacobperron jacobperron merged commit 401f6e5 into ros2 Jan 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/update_cpplint_fork branch January 12, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacobperron @clalancette