Disable mem-access warnings on aarch64. #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently a bug in Eigen in Ubuntu 22.04 meaning that it throws a mem-access warning every time Eigen/PacketMath.h is used. There is an upstream fix for it, and we are trying to get that into Ubuntu 22.04, but that is not guaranteed. For now, disable the warning only if we are on GCC or Clang and the target architecture is aarch64. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
|
Actually, this may not be the right way to do things. Converting to a draft until I figure it out. |
The comment in the code explains why we are doing this. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
All right, the latest is a much more targeted fix that I like a lot better. Changing this back to review. |
|
CI:
|
|
Thanks for the review! Going ahead and merging this one. |
delete-merged-branch
bot
deleted the
clalancette/disable-memaccess-warnings
branch
jacobperron
added a commit
that referenced
this pull request
Apr 2, 2022
Same as #506, but in a different file where Eigen headers are being included. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Apr 4, 2022
* Depend on orocos_kdl_vendor * Change package.xml dependency to the vendor package * Add missing include directories for orocos_kdl Upstream should probably be updated to use modern cmake targets. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Disable mem-access warnings on aarch64 Same as #506, but in a different file where Eigen headers are being included. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug in Eigen in Ubuntu 22.04 meaning
that it throws a mem-access warning every time Eigen/PacketMath.h
is used. There is an upstream fix for it, and we are trying
to get that into Ubuntu 22.04, but that is not guaranteed.
For now, disable the warning only if we are on GCC or Clang
and the target architecture is aarch64.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org