Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add do_transform_polygon_stamped #582

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Add do_transform_polygon_stamped #582

merged 3 commits into from
Mar 18, 2023

Conversation

tonynajjar
Copy link
Contributor

#581

This is an initial draft, please give feedback on the idea, thanks!

clalancette
clalancette requested changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, this is completely new functionality so I'm happy to have it in. There are two flake8 errors to be resolved, but once those are fixed we can run CI on it.

tf2_geometry_msgs/src/tf2_geometry_msgs/tf2_geometry_msgs.py Outdated Show resolved Hide resolved
tf2_geometry_msgs/src/tf2_geometry_msgs/tf2_geometry_msgs.py Show resolved Hide resolved
@clalancette
Apply suggestions from code review
9610082 
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@tonynajjar tonynajjar requested review from clalancette and removed request for ahcorde March 17, 2023 20:21
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 2ed3342 into ros2:rolling Mar 18, 2023
@tonynajjar
Copy link
Contributor Author

Would love to have it backported to Humble if possible

@clalancette
Copy link
Contributor

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 21, 2023
@tonynajjar @mergify
Add do_transform_polygon_stamped (#582)
3c6d8ee 
* Add do_transform_polygon_stamped

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 2ed3342)
@mergify mergify bot mentioned this pull request Mar 21, 2023
Merged
clalancette pushed a commit that referenced this pull request Mar 23, 2023
@mergify @tonynajjar
Add do_transform_polygon_stamped (#582) (#590)
d508d9c 
* Add do_transform_polygon_stamped

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 2ed3342)

Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
@CursedRock17 CursedRock17 mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonynajjar @clalancette