-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable document generation using rosdoc2 for ament_python pkgs #587
Conversation
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
examples_tf2_py/package.xml
Outdated
<exec_depend>launch_ros</exec_depend> | ||
<exec_depend>rclpy</exec_depend> | ||
<exec_depend>sensor_msgs</exec_depend> | ||
<exec_depend>tf2_ros</exec_depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this one shouldn't be necessary; this is strictly a python package, so the tf2_ros_py
dependency should be enough. The same goes for a few places below.
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Thanks for the review! I've moved The |
Out of curiousity, why did you choose this route rather than a custom |
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
To my knowledge even with a custom In my latest commit, I added custom |
Fix missing
exec_depends
inpackage.xmls
and docstrings to generate documentation without any warnings usingautodoc