Fix constantly increasing memory in std::list (backport #636) #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix constantly increasing memory in std::list When someone is constantly publishing with the same tf2 timestamp (application error, I know), the storage_ of the tf2::TimeCache grows unbounded causing system-wide memory leaks. In a ROS system, each tf2 Listener will spawn one of these TimeCache objects and thus, all ROS nodes that have any sort of tf2 listener will slowly start allocating more and more memory And also fixed the situation where two different tf2 needs to be introduced at the same timestamp. Since the tests were failing I realized that I had to dive a bit deeper into the simple solution. And extend a bit the TransformStorage clase to be comparable, now instead of just looking to the timestamps, the implementation avoids inserting duplicates in the buffer. If for some reason, someone is publishing a different Transfrom (xyz,rpy) at the same timestamp. Well, that case is not being captured now, but I'd say that's another problem Signed-off-by: Ignacio Vizzo <ignaciovizzo@gmail.com> (cherry picked from commit 1621942)
3 tasks
|
CI:
|
ahcorde
approved these changes
Feb 13, 2024
jplapp
pushed a commit
to pixel-robotics/geometry2
that referenced
this pull request
Feb 19, 2024
nachovizzo
pushed a commit
to nachovizzo/geometry2
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #636 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com