Export tf2 dependency from tf2_ros #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
|
CI is failing because this needs to be rebased after ros2/rcutils#113 was merged. @crdelsey would you mind doing a quick rebase? Thanks. |
tf2_ros brings in tf2 headers. This dependency was not being exported before. As a consequence of this, if a package included the tf2_ros package and included the `transform_listener.h` header, the package would fail to compile.
crdelsey
force-pushed
the
export_tf2_ros_dependency
branch
from
b8b9987
to
d91d6a0
Compare
|
@clalancette The branch is rebased now. |
|
|
No worries :). |
|
The unstable builds on all of this is because of a different problem unrelated to this PR. I'm going to merge this up. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf2_ros brings in tf2 headers. This dependency was not being
exported before. As a consequence of this, if a package
included the tf2_ros package and included the
transform_listener.hheader, the package would fail to compile.