Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmake_modules dependency from package.xml #83

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Remove cmake_modules dependency from package.xml #83

merged 1 commit into from
Nov 22, 2018

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Nov 21, 2018
@jacobperron jacobperron self-assigned this Nov 21, 2018
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 21, 2018
@jacobperron
Copy link
Member Author

jacobperron commented Nov 21, 2018 •
edited by tfoote
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

reran failed builds (tfoote)

tfoote
tfoote approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, rerunning windows to get a clean build. The last one had a timeout in one test.

@jacobperron jacobperron merged commit 86ed6f9 into ros2 Nov 22, 2018
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Nov 22, 2018
@jacobperron jacobperron deleted the rm_cmake_modules branch November 22, 2018 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@tfoote tfoote tfoote approved these changes

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @mjcarroll @tfoote