add a bridge mapping rule so tf/tfMessage maps to tf2_msgs/TFMessage #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
enhancement
clalancette
approved these changes
Oct 6, 2017
mikaelarguedas
approved these changes
Oct 6, 2017
There was a problem hiding this comment.
thanks for fixing this! that was a known issue we didnt find time to address and test during beta3.
I was originally concerned that the custom mapping rule would override the mapping of tf2/TFMessage but looking at the code it's just adding custom mappings to the default ones 👍
dhood
approved these changes
Oct 6, 2017
|
lgtm, thanks @dhood. |
|
@wjwwood should this be merged ? |
|
Yeah, thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this according to this doc:
https://github.com/ros2/ros1_bridge/blob/master/doc/index.rst#how-can-i-install-mapping-rule-files
And some help from @dirk-thomas.
I tested this with our HSR demo.