rename transitions as lifecycle_msgs changed #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRANSITION_SHUTDOWN is delated in lifecycle_msgs/msg/Transition.msg Align with the code changes from ros2/rcl_interfaces@852a37b Signed-off-by: Chris Ye <chris.ye@intel.com>
|
this looks correct to me, but I'd like to have @wjwwood giving his opinion as well. |
wjwwood
reviewed
Nov 1, 2018
There was a problem hiding this comment.
The code looks ok, but I have not idea about the new/changed transition states or if anything else is required to make them usable in launch. I would presume not.
I'll leave it to @Karsten1987 to do CI and final review since he authored ros2/rcl_interfaces#46.
|
In order to fix the nightlies and unblock CI for other pr's, I'll go ahead and push on it, here's CI:
|
wjwwood
approved these changes
Nov 1, 2018
|
Blocked on ros2/geometry2#76 (comment) |
|
CI:
|
|
thanks @yechun1 for providing a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TRANSITION_SHUTDOWN is delated in lifecycle_msgs/msg/Transition.msg
Align with the code changes from ros2/rcl_interfaces@852a37b
Signed-off-by: Chris Ye chris.ye@intel.com
To fix #152